This repository was archived by the owner on Jan 20, 2026. It is now read-only.
feat: optional version and name in package#324
Merged
tdejager merged 17 commits intoprefix-dev:mainfrom Sep 1, 2025
Merged
Conversation
# Conflicts: # Cargo.lock # crates/pixi-build-cmake/src/build_script.rs # crates/pixi-build-mojo/src/build_script.rs # crates/pixi-build-mojo/src/snapshots/pixi_build_mojo__tests__mojo_bin_is_set.snap # crates/pixi-build-mojo/src/snapshots/pixi_build_mojo__tests__mojo_pkg_is_set.snap # crates/pixi-build-python/src/build_script.rs # crates/pixi-build-rust/src/build_script.rs
ruben-arts
changed the title
tdejager
suggested changes
Aug 29, 2025
backends/pixi-build-ros/src/pixi_build_ros/metadata_provider.py
Outdated
Show resolved
Hide resolved
backends/pixi-build-ros/src/pixi_build_ros/metadata_provider.py
Outdated
Show resolved
Hide resolved
backends/pixi-build-ros/src/pixi_build_ros/metadata_provider.py
Outdated
Show resolved
Hide resolved
backends/pixi-build-ros/src/pixi_build_ros/metadata_provider.py
Outdated
Show resolved
Hide resolved
|
|
||
| /// Return the name of the project model | ||
| fn name(&self) -> &str; | ||
| fn name(&self) -> Option<&String>; |
Contributor
There was a problem hiding this comment.
Is Option<&str> not an option :) Could be ownership issues Idk?
Contributor
Author
There was a problem hiding this comment.
name is an Option<String> so I can't make it str without cloning. But do you think that makes sense here?
Contributor
There was a problem hiding this comment.
Maybe as_ref would convert it into a Option<&str> as well?
…re globs for metadata fetching
…ptional # Conflicts: # Cargo.lock
tdejager
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to use the optional name and version fields in the project model.
This works together with the idea of the MetadataProvider. So this PR adds that to the python bindings so the ROS backend can make use of this feature.
I've extensively tested this on my machine with the ROS workspace.
Depends on: